phillc73 / abettor

An R package for connecting to the online betting exchange Betfair, via their API-NG product, using JSON-RPC.
Other
51 stars 36 forks source link

Abettor not installing package in R version 4 #23

Closed Markov12345 closed 3 years ago

Markov12345 commented 4 years ago

Hello, Ive just upgraded toR Version r and when I try to reinstall the abbettpr package it tells me its not available for R version 4. Can this ne fixed as I need R version 4.

roseypro commented 4 years ago

Is there any update?

phillc73 commented 4 years ago

Sorry, no update. I haven't installed R version 4 anywhere in order to test. I'm pretty sure it'll be a dependency issue somewhere though.

roseypro commented 4 years ago

Thanks for reply Phill. Wasn't sure if the package was still maintained and working.

-------- Original message -------- From: Phill notifications@github.com Date: 26/05/2020 14:31 (GMT+00:00) To: phillc73/abettor abettor@noreply.github.com Cc: roseypro Chrisrose27@live.com, Comment comment@noreply.github.com Subject: Re: [phillc73/abettor] Abettor not installing package in R version 4 (#23)

Sorry, no update. I haven't installed R version 4 anywhere in order to test. I'm pretty sure it'll be a dependency issue somewhere though.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/phillc73/abettor/issues/23#issuecomment-634026594, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APXHNU6FZHRV3FOFAKLHUY3RTPADDANCNFSM4NF3KCVA.

roseypro commented 4 years ago

Is that something I can fix or would I be better off rolling back a version? Thanks Phill

Chris

-------- Original message -------- From: Phill notifications@github.com Date: 26/05/2020 14:31 (GMT+00:00) To: phillc73/abettor abettor@noreply.github.com Cc: roseypro Chrisrose27@live.com, Comment comment@noreply.github.com Subject: Re: [phillc73/abettor] Abettor not installing package in R version 4 (#23)

Sorry, no update. I haven't installed R version 4 anywhere in order to test. I'm pretty sure it'll be a dependency issue somewhere though.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/phillc73/abettor/issues/23#issuecomment-634026594, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APXHNU6FZHRV3FOFAKLHUY3RTPADDANCNFSM4NF3KCVA.

phillc73 commented 4 years ago

I guess the answer is that the package is barely maintained and it still works against the R versions I've tested it against, which sadly doesn't include v4.0. As sport and racing in general are shut down at the moment, I haven't been using the package in anger for a few months either.

I honestly can't say when I'll upgrade to R v4.0 and have a chance to test the package. Rolling back might be a better short term option.

One thing you could do to assist, could be to extract the individual functions from the package, starting with loginBF and then trying perhaps listCountries and executing them manually. Load the three libraries, RCurl, httr and jsonlite manually at the start.

If those functions continue to work with R v4.0, I'll need to dig deeper.

roseypro commented 4 years ago

Sure I'll give it a go.

Thanks again for the assistance.

-------- Original message -------- From: Phill notifications@github.com Date: 26/05/2020 15:11 (GMT+00:00) To: phillc73/abettor abettor@noreply.github.com Cc: roseypro Chrisrose27@live.com, Comment comment@noreply.github.com Subject: Re: [phillc73/abettor] Abettor not installing package in R version 4 (#23)

I guess the answer is that the package is barely maintained and it still works against the R versions I've tested it against, which sadly doesn't include v4.0. As sport and racing in general are shut down at the moment, I haven't been using the package in anger for a few months either.

I honestly can't say when I'll upgrade to R v4.0 and have a chance to test the package. Rolling back might be a better short term option.

One thing you could do to assist, could be to extract the individual functions from the package, starting with loginBFhttps://github.com/phillc73/abettor/blob/master/R/loginBF.R and then trying perhaps listCountrieshttps://github.com/phillc73/abettor/blob/master/R/listCountries.R and executing them manually. Load the three libraries, RCurl, httr and jsonlite manually at the start.

If those functions continue to work with R v4.0, I'll need to dig deeper.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/phillc73/abettor/issues/23#issuecomment-634050353, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APXHNU54VSNQHSB6PAQTLKLRTPE25ANCNFSM4NF3KCVA.

Markov12345 commented 4 years ago

Hi, Thanks for the reply. I've extracted the functions and they do still work. So Im just using them at present. The issues may just be fixed by repackaging the functions for version 4. Racing is still on in Australia so Im still running the code.

On Tue, May 26, 2020 at 11:16 PM roseypro notifications@github.com wrote:

Is there any update?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/phillc73/abettor/issues/23#issuecomment-634018138, or unsubscribe https://github.com/notifications/unsubscribe-auth/APU6HCSMEHAZBUADJDTHAPTRTO6LJANCNFSM4NF3KCVA .

phillc73 commented 4 years ago

Good news!

I'll have a look at re-packaging over the weekend if I can.

roseypro commented 4 years ago

Hi both, the package installed for me today. Think it's because I didn't have devtools installed previously. May not even need a repackage! I used install_git.

-------- Original message -------- From: Phill notifications@github.com Date: 26/05/2020 19:40 (GMT+00:00) To: phillc73/abettor abettor@noreply.github.com Cc: roseypro Chrisrose27@live.com, Comment comment@noreply.github.com Subject: Re: [phillc73/abettor] Abettor not installing package in R version 4 (#23)

Good news!

I'll have a look at re-packaging over the weekend if I can.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/phillc73/abettor/issues/23#issuecomment-634204829, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APXHNU3RVTOWCPEJQ67HDJTRTQEKFANCNFSM4NF3KCVA.