search

phillc73 / abettor

An R package for connecting to the online betting exchange Betfair, via their API-NG product, using JSON-RPC.
Other
51 stars 36 forks source link

Minor fix to prevent warnings: "No encoding supplied: defaulting to UTF-8." #31

Closed Soccerama closed 3 years ago

Soccerama commented 3 years ago

A minor fix to prevent warnings about encoding by explicitly passing encoding = "UTF-8" to the API. Functions impacted are: cancelOrders, listCompetitions, listCurrentOrders, listEventTypes, listEvents, listMarketBook, listMarketCatalogue, listMarketTypes, listVenues, placeOrders, replaceOrders, updateOrders

Soccerama commented 3 years ago

This Pull Request now also includes changes to listEvents so that they correctly manage timezones and updated documentation to note that system requires UTC.

Soccerama commented 3 years ago

And have also updated other functions to use UTC by default. This will only impact users outside UK, and even then only matters for some functions, but have gone through and applied the change consistently.