Rename checkBalance and listMarketPandL Functions

phillc73 / abettor

An R package for connecting to the online betting exchange Betfair, via their API-NG product, using JSON-RPC.

Other

51 stars 36 forks source link

Rename checkBalance and listMarketPandL Functions #44

Closed phillc73 closed 3 years ago

phillc73 commented 3 years ago

The functions checkBalance and listMarketPandL should be renamed to match the naming convention used in the Betfair API calls, for consistency with the rest of the library.

Specifically that is:

checkBalance to getAccountFunds
listMarketPandL to listMarketProfitAndLoss

Old function names should re-direct to new function names for backwards compatibility.

Soccerama commented 3 years ago

Completely agree with this proposed change and had thought the same thing myself. My only reservation was the backwards issue but a simple redirect should manage that.

phillc73 commented 3 years ago

Completed with commit https://github.com/phillc73/abettor/commit/19f6688ffb255a6f173acaabd25d37218790eaed