search

phillc73 / abettor

An R package for connecting to the online betting exchange Betfair, via their API-NG product, using JSON-RPC.
Other
51 stars 36 forks source link

Fixed typo in GetMyData() with sslVerify in function arguments #45

Closed Soccerama closed 3 years ago

Soccerama commented 3 years ago

Relates to #32. Also some minor doc edits. I've done this through a branch so it should only pull this file and not the others I'm working on. Please let me know if there is an issue with this - it's the first time I've used it.

phillc73 commented 3 years ago

Thanks for fixing the typos with GetMyData(). It must have been late on my end. I've cherry picked that commit and merged with the master branch.

Regarding the other commits, there's a couple I don't need - "Clean up....." and "Merge pull request...."

It looks like the placeOrdersDF() function is still calling an undefined insts within the main function. The documentation for this function would also need to be updated with the new function name.

In general, I would be happy that this function replaces the existing one, if everything from the existing one still works. In the meantime, if you want to merge this function into the master branch, perhaps we could think of a different name, something a little more descriptive. Some ideas:

I'm just not the biggest fan of adding only "DF" here. I know it means you're constructing a dataframe, but I'm not sure it's intuitive for other users.

Soccerama commented 3 years ago

Sorry, the pull request was meant to be just the fix typos commit, others are mostly just my sandpit. Still learning how to use this thing... The placeOrdersDF was not meant to be here (and it is a stale version in this branch anyway). My modified placeOrders function is discussed in issue #43 with the code in my placeOrders fork - I think.

phillc73 commented 3 years ago

No problem. I learned quite a lot about git cherry-pick functionality!