search

philliplab / ViralHaplotyper

0 stars 0 forks source link

think carefully about the output data structures of get_unique_sequence_details #35

Closed philliplab closed 9 years ago

philliplab commented 9 years ago

1) BStringSet + data.frame - output a list with these two elements

2) data.frame + a BStringSet converter - solid option - computational inefficiency should not be a problem?

or just a BStringSet + a data.frame converter? <- Not this one since parsing requires too much information.

Currently leaning towards option 1 since it is the least ambiguous and uses the data structures as they were intended to be used.

philliplab commented 9 years ago

Actually just choose option 1 since it is the right thing to do. The extra little bit of code to annotate the sequence_names is irrelevant in the greater scheme of things, but improper use of the data structures might cause many issues in the future.