phillipsnick / denon-avr

Denon AVR remote control via RS232 or IP (Telnet)
MIT License
35 stars 8 forks source link

Now we depends on fresh telnet-client v0.7.0. #12

Closed aborovsky closed 1 year ago

aborovsky commented 8 years ago

Please, help to test my PR in all ways and merge it with your repo.

phillipsnick commented 8 years ago

Hey

I'd love to switch to the more popular telnet-client instead of my own fork. But it isn't really working as I'd like. The biggest problem being the chaining of requests, which your pull request on my fork fixed: https://github.com/phillipsnick/node-telnet-client/pull/9

I have an example here: https://github.com/phillipsnick/denon-avr/blob/chain-requests/examples/telnet/chain.js

Had a little play with telnet-client v0.7.0 but I can't get multiple requests working properly.

Could you maybe put an example file in with it working?

aborovsky commented 8 years ago

I've fixed a lot and tested well.

Now it's working with fresh telnet-client and self-written tiny queue handling inside of /lib/telnet.js method 'handleQueue'

phillipsnick commented 8 years ago

I like the idea, would you be able to adjust the pull request to use 2 space indentation to match the existing code?

I'll then have a proper play and see if it works with my automation system.

aborovsky commented 8 years ago

No problem, I'll fix identation. Вт, 1 марта 2016 г. в 2:56, Nick Phillips notifications@github.com:

I like the idea, would you be able to adjust the pull request to use 2 space indentation to match the existing code?

I'll then have a proper play and see if it works with my automation system.

— Reply to this email directly or view it on GitHub https://github.com/phillipsnick/denon-avr/pull/12#issuecomment-190455121 .

[image: BeeToo] http://beetoo.me/ Когда умный дом по-настоящему умный Александр Боровский, Технический директор Alexander Borovsky, CTO, Co-Founder +7-926-0-945-00 <+7926094500> +7-499-391-33-62 <+74993913362>aborovsky@beetoo.me http://beetoo.me

aborovsky commented 8 years ago

Identation and other spaces fixed!