SubindexNode is not attached to the AST

Z-Gu commented 6 years ago

The subindexNode (corresponding to (i : 0 to 2) for a base signal) is created in the following code section and never attached to the AST. newton-parser.c:364

    IrNode * subindexNode;
    if (lexPeek(N, 5)->type == kNewtonIrNodeType_Tto)
    {
        subindexNode = newtonParseSubindexTuple(N, currentScope);
        subindexStart = subindexNode->subindexStart;
        subindexEnd = subindexNode->subindexEnd;

        assert(subindexEnd > 0);
    }

hyuglim commented 6 years ago

I will work on it this weekend.

Jonathan

On Dec 16, 2017 7:07 PM, "Zhengyang Gu" notifications@github.com wrote:

The subindexNode (corresponding to (i : 0 to 2) for a base signal) is created in the following code section and never attached to the AST. newton-parser.c:364

IrNode * subindexNode; if (lexPeek(N, 5)->type == kNewtonIrNodeType_Tto) { subindexNode = newtonParseSubindexTuple(N, currentScope); subindexStart = subindexNode->subindexStart; subindexEnd = subindexNode->subindexEnd;
  assert(subindexEnd > 0);
}

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/phillipstanleymarbell/Noisy-lang-compiler/issues/161, or mute the thread https://github.com/notifications/unsubscribe-auth/ADEhbgnEEX-3F1jEOksUyrZ15oR84aXQks5tBIV9gaJpZM4REh7R .

phillipstanleymarbell commented 6 years ago

This is still open...

phillipstanleymarbell commented 5 years ago

This should no longer be relevant / fixed as part of #330. Moving to verify.

phillipstanleymarbell / Noisy-lang-compiler

SubindexNode is not attached to the AST #161