philloooo / github-tests

just for testing various github features/bugs
Apache License 2.0
0 stars 0 forks source link

PXD-284 ⁃ Remove warning from the token-create #286

Open skattar1406 opened 6 years ago

skattar1406 commented 6 years ago
Warning: A value for key GOOGLE_API_KEY not found. Defaulting to ""...
Warning: A value for key GOOGLE_PROJECT_ID not found. Defaulting to ""...
Warning: A value for key GOOGLE_ADMIN_EMAIL not found. Defaulting to ""...
Warning: A value for key GOOGLE_IDENTITY_DOMAIN not found. Defaulting to ""...
Warning: A value for key GOOGLE_CLOUD_IDENTITY_ADMIN_EMAIL not found. Defaulting to ""...

remove those warning from standard output of fence-create token-create command

skattar1406 commented 6 years ago

➤ Rudyard Richter commented:

(I recommend just putting this on stderr)

skattar1406 commented 6 years ago

➤ Yajing Tang commented:

it goes to stderr directly, docker merge both stdout and stderr

skattar1406 commented 6 years ago

➤ Rudyard Richter commented:

I thought that's only if you run docker with a TTY open?

skattar1406 commented 6 years ago

➤ Yajing Tang commented:

typo, k8s merge both. When you do kubectl logs it mixes docker's stdout and stderr

skattar1406 commented 6 years ago

➤ thanhnguyendang commented:

when I run kubectl exec, it also has both in the output. And that is the way we run to create the access_token now. Anyway, where do you check those keys?

skattar1406 commented 6 years ago

➤ Yajing Tang commented:

oh I see, I thought you were talking about the service logs, which for nginx/apache2 all python logs go to error log, then forward to docker stderr. For the fence-create, I think it's better to allow an optional param to set log level?

skattar1406 commented 6 years ago

➤ Rudyard Richter commented:

If you need to run kubectl exec to use fence-create and don't care about the warnings, then you can just add 2> /dev/null in the command to ignore them.

@thanh-nguyen-dang