search

phillord / lentic

Create views of the same content in two Emacs buffers
183 stars 12 forks source link

`lentic-doc-external-view' launch eww #18

Closed tumashu closed 9 years ago

tumashu commented 9 years ago 
(defun lentic-doc-external-view ()
  (interactive)
  (lentic-doc-ensure-doc)
  (browse-url-of-file lentic-doc-file))

I use GNU Emacs 24.4.1 (i686-pc-mingw32)GNU Emacs 24.4.1 (i686-pc-mingw32) `lentic-doc-external-view' lanuch eww instead of ie ,

I think we should use:

(defun lentic-doc-external-view ()
  (interactive)
  (lentic-doc-ensure-doc)
  (browse-url-default-browser lentic-doc-file))
phillord commented 9 years ago

Can you explain a bit more please. What are you seeing that you don't like, and how would this change improve the situation?

tumashu commented 9 years ago

The reason is that we have lentic-doc-eww-view', Iflentic-doc-external-view' launch eww, it seem meanless.

phillord commented 9 years ago

tumashu notifications@github.com writes:

The reason is that we have lentic-doc-eww-view', Iflentic-doc-external-view' launch eww, it seem meanless.

Reply to this email directly or view it on GitHub: https://github.com/phillord/lentic/issues/18#issuecomment-74665522

Yes. Are you saying this is what happens? For me, lentic-doc-external-view pops up an external browser.

Phil

tumashu commented 9 years ago

lentic-doc-external launch eww in my machine

phillord commented 9 years ago

Okay, will fix. Thanks for the report!