search

phillord / lentic

Create views of the same content in two Emacs buffers
183 stars 12 forks source link

Bug with unmatched chunks #40

Closed lionel- closed 8 years ago

lionel- commented 8 years ago

It happens when two different types of blocks are used.

To reproduce, copy the following in a new .org file:

#+BEGIN_SRC clojure
(some-code)
#+END_SRC

#+BEGIN_SRC other-lang
example
#+END_SRC

# Local Variables:
# lentic-init: lentic-org-clojure-init
# End:

Then:

This results in the original creator buffer getting commented everywhere. It also does weird things to the undo history and it's not possible to get back to the original text.

phillord commented 8 years ago

Thanks for the report, I've reproduced the behaviour now. Not sure of the cause yet, but will investigate when I can.

phillord commented 8 years ago

Found the cause -- the "invert" function is wrong, so it's running an unmatched transform in one direction and matched in the other.

Thinking about a solution, but it's not going to be immediate, I am afraid.

Phil

Lionel Henry notifications@github.com writes:

It happens when two different types of blocks are used and we try to modify a "non-native" chunk.

To reproduce, copy the following in a new .org file:


#+BEGIN_SRC clojure
(some-code)
#+END_SRC

#+BEGIN_SRC other-lang
example
#+END_SRC

# Local Variables:
# lentic-init: lentic-org-clojure-init
# End:

Then:

  • create a lentic buffer and switch to it
  • make a change in the buffer.

This results in the original creator buffer getting commented everywhere. It also does weird things to the undo history and it's not possible to get back to the original text.

Reply to this email directly or view it on GitHub: https://github.com/phillord/lentic/issues/40

phillord commented 8 years ago

This should be fixed now, I believe. The "weird things with the undo" should also be fixed also, but am afraid this required core emacs updates -- so it will only be on Emacs-25.

lionel- commented 8 years ago

Thanks a lot Phil! I saw you struggle on emacs-devel with that undo thing ;) Glad it's worked out.

phillord commented 8 years ago

Took a bit longer than I expected, I have to admit, but I learned a lot and Stefan was tremendously helpful. Looks like master is still broken as a result, though! Oh dear.