search

phillord / tawny-owl

Build OWL Ontologies in a Programmatic Environment
GNU Lesser General Public License v3.0
251 stars 54 forks source link

memorise: Wrong number of args (0) passed to: tawny.owl/ontology-options #74

Closed dfornika closed 4 years ago

dfornika commented 4 years ago

The tawny.memorize/memorise function seems to be failing with the error message:

Execution error (ArityException) at tawny.memorise/fetch-remembered-entities (memorise.clj:83).                                                            
Wrong number of args (0) passed to: tawny.owl/ontology-options

memorise calls fetch-remembered-entities, which calls tawn.owl/ontology-options with no arguments, but ontology-options takes a single argument.

phillord commented 4 years ago

Does this work?

dfornika commented 4 years ago

Hi @phillord thanks for addressing this issue. It might take me some time to find the development environment I was using when I ran into this issue, so I may not be able to quickly confirm that it works for me.

But it certainly looks like a reasonable fix so if it's working on your system then please go ahead with merging it even if I'm not able to confirm.

dfornika commented 4 years ago

@phillord Ok, I can report back now that this does fix my issue.

I have this repo for a tawny version of the Sequence Ontology:

https://github.com/dfornika/tawny-so

I read the ontology here:

https://github.com/dfornika/tawny-so/blob/master/src/tawny/obo/so.clj

...and used your updated code to memorise the ontology here:

https://github.com/dfornika/tawny-so/blob/master/src/tawny/obo/so_memorise.clj

phillord commented 4 years ago

Thanks for testing! This is one of the hardest bits to test, so it's good to get confirmation.