🐛 Bug: Use an HTML <details> tag for calendar subscription links - Githubissues

philly-js-club / philly-js-club-website

The website for Philly JS. Powered by React, Remix, and TypeScript. 🔔✨

https://phillyjs.com

MIT License

9 stars 17 forks source link

🐛 Bug: Use an HTML <details> tag for calendar subscription links #107

Closed JoshuaKGoldberg closed 3 months ago

JoshuaKGoldberg commented 4 months ago

Bug Report Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Expected

The calendar subscription links on https://phillyjs.com/events can be implemented with a browser-native <details> + <summary>.

Actual

https://github.com/philly-js-club/philly-js-club-website/blob/a4836fb72a79631f3e3ec8ed7cde54ea3a6cb30a/app/components/CalendarSubscriptionLinks.tsx#L13-L22

Additional Info

This is broken on production now because we aren't deploying any corresponding JS scripts. Whoops.

cc @RNR1

💖