philly-js-club / philly-js-club-website

The website for Philly JS. Powered by React, Remix, and TypeScript. 🔔✨
https://phillyjs.com
MIT License
9 stars 14 forks source link

Tool/handle remix warning, resolve #46 #48

Closed chethtrayen closed 1 year ago

chethtrayen commented 1 year ago

PR Checklist

Overview

Stop Remix build warning. Add serverModuleFormat: "cjs" to remix config.

tjwds commented 1 year ago

👍🏻 Thanks!

It looks like there's some extra commits on this branch; let me know if you'd like advice on how to remove those :-)

chethtrayen commented 1 year ago

👍🏻 Thanks!

It looks like there's some extra commits on this branch; let me know if you'd like advice on how to remove those :-)

Yes please I have tried and failed.

tjwds commented 1 year ago

I think what happened at first was that you had my Remix update branch checked out when you checked out a new branch to make this commit!

So here's how I'd fix it:

(There's other ways to approach this, but that's the most straight-forward, imo.)

chethtrayen commented 1 year ago

I think it worked?

tjwds commented 1 year ago

Thanks for putting this together!