🚀 Feature: Highlight Active Footer Navigation - Githubissues

philly-js-club / philly-js-club-website

The website for Philly JS. Powered by React, Remix, and TypeScript. 🔔✨

https://phillyjs.com

MIT License

9 stars 13 forks source link

🚀 Feature: Highlight Active Footer Navigation #58

Closed codylewis closed 11 months ago

codylewis commented 1 year ago

Bug Report Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Overview

User story

As a user, I want the site navigation to communicate where I am in the site.

Acceptance criteria

Links in the site footer should the color white when the user is on that page
- As of creating this issue this applies to:
  - About
  - Code of Conduct
  - Events
  - Sponsors
  - Join Us

Additional Info

No response

RNR1 commented 1 year ago

In addition to that, we currently use a simple anchor tag for the navigation links, which causes a full page load for every click.

We should use the NavLink component, which will also contain the "active" class to indicate which nav item is currently active

tjwds commented 1 year ago

So… it turns out the ~annoying~ bespoke deployment situation I've set up doesn't play nicely with NavLink. We'll have to do something else here!