philly-js-club / philly-js-club-website

The website for Philly JS. Powered by React, Remix, and TypeScript. šŸ””āœØ
https://phillyjs.com
MIT License
9 stars 13 forks source link

fix: pin isbot to 3.x #86

Closed brophdawg11 closed 6 months ago

brophdawg11 commented 6 months ago

PR Checklist

Overview

Fix broken deploys from the isbot@4 - Internal remix entry.server.tsx file relies on isbot@3

brophdawg11 commented 6 months ago

So by default you own your entry points (entry.server.tsx, entry.client.tsx), but since they are mostly boilerplate and donā€™t often need to be customized - you are able to delete them and remix has its own internal implementations (currently using the isbot v3 API). One Joe updated the dep to v4, things went awry since the internal impl still assumes v3 (weā€™ll be fixing this assumption in the next remix release)

If you run npx remix reveal youā€™ll see the ā€œnormalā€ setup which removes the ā€œhiddenā€ usage - so that could be more appropriate for a shared repo such as this one where different folks with different levels of Remix familiarity will be contributing.

tjwds commented 6 months ago

One Joe updated the dep to v4, things went awry since the internal impl still assumes v3 (weā€™ll be fixing this assumption in the next remix release)

That's not quite true ā€”Ā I updated to v4 just to see if that would fix the issue before moving on with my day :-)

I think what happened is:

brophdawg11 commented 5 months ago

Oh interesting, my bad. I think I thought we installed latest at app creation but that it left the numerical version in package json after that, not ā€˜latestā€™ verbatim. Does pnpmā€™s lock file not store the v3 version resolved to by ā€˜latestā€™? Or does the cron job do a full reinstall and not use the lock file (I.e., npm install versus npm ci)? Iā€™m not too familiar with pnpm.

Arenā€™t y2k bugs fun?!?