philmmanjaro / project-sx

The next big thing
6 stars 2 forks source link

tlpui update needed #11

Closed oberon-manjaro closed 6 years ago

oberon-manjaro commented 6 years ago

Since gksu has been dropped I have attempted to update tlpui. Apparently the repo has been redesigned, using setuptools now. However unfortunately I was not able to get the application working ... @philmmanjaro please have a look, thank! :smiley: https://github.com/philmmanjaro/project-sx/blob/master/packages/tlpui/PKGBUILD

philmmanjaro commented 6 years ago

We always used polkit for it. Never used gksu? Did I miss some?

philmmanjaro commented 6 years ago

OK, my bad. We used gksu for it in the past.

philmmanjaro commented 6 years ago

https://github.com/philmmanjaro/project-sx/commit/6d2459fd6cc06a8ff3442f7a25d9118b4a4ab62e

philmmanjaro commented 6 years ago

https://github.com/philmmanjaro/project-sx/commit/7834cf13cfc93a7048398ab360b87b0b6fc65434

oberon-manjaro commented 6 years ago
Traceback (most recent call last):
  File "/usr/bin/tlp_ui", line 11, in <module>
    load_entry_point('TLPUI==0.1', 'gui_scripts', 'tlpui')()
  File "/usr/lib/python3.6/site-packages/tlpui/__main__.py", line 31, in main
    window.add(create_main_box(window))
  File "/usr/lib/python3.6/site-packages/tlpui/mainui.py", line 261, in create_main_box
    configbox = create_config_box(window)
  File "/usr/lib/python3.6/site-packages/tlpui/configui.py", line 25, in create_config_box
    tlp_categories = get_tlp_categories(window, categories)
  File "/usr/lib/python3.6/site-packages/tlpui/configui.py", line 230, in get_tlp_categories
    configbox = create_item_box(configobjects, description, grouptitle, window)
  File "/usr/lib/python3.6/site-packages/tlpui/configui.py", line 120, in create_item_box
    tlpobject = settings.tlpconfig[configname]
KeyError: 'USB_BLACKLIST_PRINTER'

The issue doesn't seem to be related to polkit ... What is it about KeyError ?

d4nj1 commented 6 years ago

Hi. USB_BLACKLIST_PRINTER was introduced in TLP 1.1 (https://github.com/linrunner/TLP/releases/tag/1.1) Maybe your tlp config file in /etc/default/tlp is not up to date. Could you please check this and add USB_BLACKLIST_PRINTER to it?

If this is not the problem, please open a bug request at https://github.com/d4nj1/TLPUI with your TLP version and the TLPUI version you use.

oberon-manjaro commented 6 years ago

Thanks a lot! I had to merge the recent config, now it works as expected! :+1:

philmmanjaro commented 6 years ago

@d4nj1: thx for your feedback. It is always good to have direct contact with the author :+1: