search

philn / gnome-shell-gajim-extension

[UNMAINTAINED] Gajim IM integration in GNOME Shell
GNU General Public License v3.0
18 stars 2 forks source link

Extension bypasses OTR encryption #4

Closed bunghole closed 11 years ago

bunghole commented 11 years ago

Greetings,

I really love your extension, it actually made me switch from Pidgin to Gajim. But for some reason, it looks like answering a conversation through the notification pop up bypasses the Off The Record plugin, which means outgoing messages aren't encrypted.

Any idea how to fix this?

philn commented 11 years ago

Thanks for the bug report! I suspect this issue happens because I set the keyID parameter of the send_chat_message Gajim function to empty string. Would you be able to verify this? Not sure what that keyID is though, perhaps your GPG id.

I'll think about how to properly fix this.

bunghole commented 11 years ago

Thanks for your reply! :)

Looks like the keyID parameter targets the build in OpenPGP encryption, which isn't the same as the OTR encryption plugin (even though it probably does the same thing, but most of my contacts prefer OTR since it is more convenient to use).

philn commented 11 years ago

I think this might be a bug in Gajim, actually. Filed https://trac.gajim.org/ticket/7321

bunghole commented 11 years ago

Ah, I see! Well then, let's hope the devs are on their toes...

I'll keep an eye on the Ticket you've filed and check the latest hg source as soon as a fix is proposed.

Thanks for your effort so far! :)

Asterix78 commented 11 years ago

Fixed upstream

philn commented 11 years ago

That was quick, thanks a lot :)

bunghole commented 11 years ago

REALLY quick, impressive, thx! :)

I can confirm that sending OTR encrypted messages via extension works now - maybe even a bit too well, since send messages (both from within Gajim and notification area) now show up encrypted in the notification bubble, but that's ok...

Thx again for your effort to both Asterix78 & philn! :)

philn commented 10 years ago

I've just fixed #7 which is the issue you mentioned in your last comment :)