search

philnash / bitly

🗜 A Ruby wrapper for the bit.ly API
https://rubygems.org/gems/bitly
MIT License
451 stars 139 forks source link

Configure bitly through initializer #16

Closed sylturner closed 11 years ago

sylturner commented 12 years ago

I added the optional ability to set username, api_key, and api_version through a Rails initializer. If configured that way, you get the client with the method Bitly.client

Added the Config class, added the client method in Bitly, updated the readme, and added some tests.

marckohlbrugge commented 12 years ago

Is there a reason this hasn't been merged into master yet? It seems like a nice addition. (I've been using it for a while now.)

sguha00 commented 12 years ago

+1 for merge

ketan37dm commented 11 years ago

Please add this to master asap. BTW thanks "Syl Turner" for such a fantastic addition to bitly gem. Nice work.

jalcine commented 11 years ago

:+1: @philnash what's the deal? :)

philnash commented 11 years ago

Apologies for what was a ridiculous wait for this. I have merged this to master, but it didn't auto close the pull request. Look out for this in a new version of the gem soon.

jalcine commented 11 years ago

No worries, @philnash! You're awesome for doing it!