philnash / bitly

🗜 A Ruby wrapper for the bit.ly API
https://rubygems.org/gems/bitly
MIT License
451 stars 139 forks source link

Test passing without actually testing outcome #58

Closed ahmetabdi closed 10 years ago

ahmetabdi commented 10 years ago

https://github.com/philnash/bitly/blob/master/test/bitly/test_client.rb#L23

assert_equal login, login should be... assert_equal login, b.login

ahmetabdi commented 10 years ago

https://github.com/philnash/bitly/pull/59

philnash commented 10 years ago

Merged #59, thanks!