search

philnash / bitly

🗜 A Ruby wrapper for the bit.ly API
https://rubygems.org/gems/bitly
MIT License
451 stars 139 forks source link

Add optional state param to OAuth2 authorize_url #63

Closed jfiorato closed 9 years ago

jfiorato commented 9 years ago

Adding the optional state parameter that is documented here to the authorize_url method.

philnash commented 9 years ago

Hey, that looks good, thanks! Can I ask why activesupport was added to the development dependencies in the gemspec though?

jfiorato commented 9 years ago

@philnash Short answer is that the shoulda gemspec results in a bundle of incompatible gems.

Long answer is: shoulda depends on shoulda-matchers, which in turn depends active-support >= 3.0.0

active-support 4.2 depends on minitest ~> 5.1

minitest 5.1 is incompatible with test-unit, in which shoulda-context-1.2.1 depends on.

shoulda also depends on shoulda-context

Without pinning active-support to ~> 3.2, then the following exception occurs when running unit tests:

undefined method '_run_suite' for class 'Test::Unit::Runner' (NameError)

Someone in there should update their gemspec, but not exactly sure who.

philnash commented 9 years ago

@jfiorato That... makes a lot of sense! I had trouble with shoulda and minitest when upgrading Rails apps a while back. I will get this merged.

philnash commented 9 years ago

Ok, this is available in the latest version 0.10.4