Closed jfiorato closed 9 years ago
Hey, that looks good, thanks! Can I ask why activesupport
was added to the development dependencies in the gemspec though?
@philnash Short answer is that the shoulda
gemspec results in a bundle of incompatible gems.
Long answer is:
shoulda
depends on shoulda-matchers
, which in turn depends active-support >= 3.0.0
active-support 4.2
depends on minitest ~> 5.1
minitest 5.1
is incompatible with test-unit
, in which shoulda-context-1.2.1
depends on.
shoulda
also depends on shoulda-context
Without pinning active-support
to ~> 3.2
, then the following exception occurs when running unit tests:
undefined method '_run_suite' for class 'Test::Unit::Runner' (NameError)
Someone in there should update their gemspec, but not exactly sure who.
@jfiorato That... makes a lot of sense! I had trouble with shoulda and minitest when upgrading Rails apps a while back. I will get this merged.
Ok, this is available in the latest version 0.10.4
Adding the optional
state
parameter that is documented here to theauthorize_url
method.