fix: fix obtaining clicks for not an bit.ly link

philnash / bitly

🗜 A Ruby wrapper for the bit.ly API

https://rubygems.org/gems/bitly

MIT License

451 stars 139 forks source link

fix: fix obtaining clicks for not an bit.ly link #74

Closed dsalahutdinov closed 6 years ago

dsalahutdinov commented 6 years ago

Hi, @philnash

I have a link like https://www.oreilly.com/ideas/how-to-build-analytic-products-in-an-age-when-data-privacy-has-become-critical which is shortened by bitly to link like https://oreil.ly/2G4Hob0 So in that way I could not obtain clicks, because method is_a_short_url? does not work with 'https'

🔥

binodmainali commented 6 years ago

👍 I am also facing the same issue, @philnash when will this be merged and timeline you have in mind Need this fix as 50% link we generate are Branded sub domain links

philnash commented 6 years ago

Sorry everyone, haven't been paying enough attention to PRs. Thanks for fixing this. I'll release a new version with this now.