philnash / jekyll-gzip

Generate gzipped assets and files for your Jekyll site at build time
https://rubygems.org/gems/jekyll-gzip
MIT License
37 stars 8 forks source link

Doesn't work with assets generated by Jekyll-Assets #1

Closed philnash closed 6 years ago

philnash commented 6 years ago

When working on philna.sh I noticed that this successfully compresses HTML files, but the assets are generated by jekyll-assets (currently version 2.4, though this should be upgraded to version 3) and are not compressed.

Need to look at how Jekyll Assets handles the files and if this project can hook into the Jekyll Assets process to generate compressed files too.

philnash commented 6 years ago

Perhaps this shouldn't be the job of this gem. Assets that are looked after by an alternative gem should be compressed by that gem, or an extension to that gem, themselves.

Perhaps look into including gzip/zopfli/brotli compression in jekyll-assets first.

philnash commented 6 years ago

This now listens for the Jekyll::Assets hook and compresses everything in the output directory.