Allow specifying a proxy in request options (#21).

philnash / pwned

😱 An easy, Ruby way to use the Pwned Passwords API.

https://rubygems.org/gems/pwned/

MIT License

421 stars 22 forks source link

Allow specifying a proxy in request options (#21). #22

Closed dparpyani closed 3 years ago

dparpyani commented 3 years ago

For #21

dparpyani commented 3 years ago

@philnash hm are the ruby-head failures expected?

philnash commented 3 years ago

Ah, yes, I think so. I have already excluded Rails 5/Ruby 3 tests, because they do not work. These failures are in Rails 5 (well, active record 5) and Ruby head, so are expected. I don't think you have anything to worry about there.

(Side note: it's funny to me that Rails 4 seems to work with Ruby 3, but Rails 5 doesn't. 🤷‍♂️)

dparpyani commented 3 years ago

Gotcha, thanks. Yeah, the Rails 4 compatibility with ruby-head is funny indeed!

Let me know if I missed something in this PR. Also, once it is merged, I would appreciate a release so we can start using it in our codebase 😄

dparpyani commented 3 years ago

@philnash 👋 any ETA on a review?

dparpyani commented 3 years ago

Thanks!