search

philnash / pwned

😱 An easy, Ruby way to use the Pwned Passwords API.
https://rubygems.org/gems/pwned/
MIT License
424 stars 22 forks source link

Support for Pwned API v3 #29

Closed basex closed 2 years ago

basex commented 2 years ago

Documentation: https://haveibeenpwned.com/api/v3

tvanderpol commented 2 years ago

I like this gem and the pwned service so I figured I'd have a look - the end point is identical and as far as I can see, the behaviour is completely unchanged.

philnash commented 2 years ago

Thanks for being proactive @basex and thanks for looking into it @tvanderpol. As far as I understand the Pwned Passwords section of the Have I Been Pwned API has not changed between v2 and v3, so there's no work needed for this gem.

I'll close this for now, but let me know if I've misunderstood something.

basex commented 2 years ago

Sorry, I was not aware it was using only that endpoint.

Either way, I suggest a small update to the documentation since it explicitly says v2: https://github.com/philnash/pwned/pull/30

philnash commented 2 years ago

Reopened, that's a good idea, thanks!

philnash commented 2 years ago

@basex I'm about to get on a plane, would love it if you were able to contribute a PR to make this more obvious.

edit just saw that you did, amazing, thank you!

philnash commented 2 years ago

I've merged the PR, thanks again for noticing this and updating it!