search

philnash / pwned

😱 An easy, Ruby way to use the Pwned Passwords API.
https://rubygems.org/gems/pwned/
MIT License
421 stars 22 forks source link

Change validator to not_pwned #8

Closed philnash closed 6 years ago

philnash commented 6 years ago

This addresses #7 to change the ActiveModel validator to used not_pwned over pwned so that it reads better.

class User < ApplicationRecord
  validates :password, not_pwned: true
end

The old version is still present, but deprecated.

philnash commented 6 years ago

Interested to hear what you think @kpumuk?

kpumuk commented 6 years ago

Logically it totally makes sense. Not a big fan of the name tho :-) But due to the lack of better alternatives – why not.