search

philogb / jit

The JavaScript InfoVis Toolkit provides tools for creating Interactive Data Visualizations for the Web
http://thejit.org
Other
1.51k stars 297 forks source link

Update build to create example folders. #120

Closed Helibobs closed 12 years ago

Helibobs commented 12 years ago

On a windows system, the build process needs to create the example sub folders, in order to progress.

Signed-off-by: helibobs helenm.666@hotmail.co.uk

Helibobs commented 12 years ago

Yes, I agree, but I am a little confused? Although the git hub viewer shows it as non-indented, it is actually indented in the committed file?

https://github.com/Helibobs/jit/blob/auto_create_example_branches/make.py#L95.

Having said that my change could be indented a little too much, after looking at it? Thanks

philogb commented 12 years ago

Are you using tabs or spaces? I think that python files have 4-space indentation.

On Wed, Aug 22, 2012 at 1:47 AM, Helibobs notifications@github.com wrote:

Yes, I agree, but I am a little confused? Although the git hub viewer shows it as non-indented, it is actually indented in the committed file?

https://github.com/Helibobs/jit/blob/auto_create_example_branches/make.py#L95.

Having said that my change could be indented a little too much, after looking at it? Thanks

— Reply to this email directly or view it on GitHubhttps://github.com/philogb/jit/pull/120#issuecomment-7928124.

Nicolas Garcia Belmonte - http://philogb.github.com/

Helibobs commented 12 years ago

Apologies for that, not much of a python programmer. Have amended the commit to use spaces. Thanks.

philogb commented 12 years ago

Merged, thanks!