philogb / jit

The JavaScript InfoVis Toolkit provides tools for creating Interactive Data Visualizations for the Web
http://thejit.org
Other
1.51k stars 297 forks source link

Build.py generated jit.js with incorrect syntax #27

Closed longsoft-dev closed 14 years ago

longsoft-dev commented 14 years ago

The current master branch as of Jun 11 2010: line 7503 & 9809 & 13103 shouldn't have the comma: type: 'Circles', line 11262 shouldn't have the extra comma too line 13702 has extra comment end token "*/"

This nightly build seems totally broken in IE6

philogb commented 14 years ago

Thanks for the heads up, I've been moving things around to be able to write proper documentation.

You can try with the recent push, please confirm that things are working well,

longsoft-dev commented 14 years ago

Hi phil, After you have fixed Icicle.js as pointed out in http://github.com/philogb/jit/issues/closed#issue/29/comment/279342, you can safely close this issue as I have tested it worked in IE then.

philogb commented 14 years ago

I think this is fixed now. You should check the demos at http://thejit.org/demos/