search

philogb / jit

The JavaScript InfoVis Toolkit provides tools for creating Interactive Data Visualizations for the Web
http://thejit.org
Other
1.51k stars 297 forks source link

Fixes issue #96 #99

Closed pedrofaustino closed 12 years ago

philogb commented 12 years ago

How about changing window.$jit with this.$jit? I think it would be better considering all the variable hoisting "things" that happen with variable declarations.

pedrofaustino commented 12 years ago

That also works. 'this' will be DedicatedWorkerContext when executed inside a Worker script, and thus will be behave in the same way as with DOMWindow. Shall I send a new pull request?

On 5 January 2012 18:42, nicolas garcia belmonte < reply@reply.github.com

wrote:

How about changing window.$jit with this.$jit? I think it would be better considering all the variable hoisting "things" that happen with variable declarations.

Reply to this email directly or view it on GitHub: https://github.com/philogb/jit/pull/99#issuecomment-3373233