Compiling on SL with today's v8 checkout causes namespace reference errors

philogb / v8-gl

A Toolkit for creating Desktop Hardware Accelerated Graphics with JS.

343 stars 32 forks source link

Compiling on SL with today's v8 checkout causes namespace reference errors #3

Closed lpsantil closed 14 years ago

lpsantil commented 14 years ago

This just might be because of a new a new struct in v8. But compiling on SL brings several of these errors

v8-gl.cpp: In function ‘v8::Handlev8::Value load(const v8::Arguments&)’: v8-gl.cpp:105: error: reference to ‘Utils’ is ambiguous utils.h:4: error: candidates are: namespace Utils { } v8/include/v8.h:109: error: struct v8::Utils

Fixing this is as simple renaming the namespace and fixing up all the references.

philogb commented 14 years ago

should be fixed now. I should put constraints as to what version of v8 should be used

lpsantil commented 14 years ago

I don't see why. It's working great. Just a namespace collision. And things that are not obviously specific to v8 could be a source of confusion. I'm seeing a lot projects using a "common.js" file these days. Now that's starting to become too common. :/