philomena-dev / philomena

Next-generation imageboard
GNU Affero General Public License v3.0
84 stars 29 forks source link

Crypto Features Package #178

Closed JasminDreasond closed 1 year ago

JasminDreasond commented 1 year ago

https://rabby.io/ I am recommending this crypto wallet for testing. but any other crypto wallet application that uses the metamask protocol will work too.

Meow commented 1 year ago

Pull Request closed due to not meeting code quality standards of the project (too many issues with it to go over in a simple code review, sorry). The commit names are also not meaningful whatsoever and there are hundreds of them, most seemingly only changing one line of code multiple times in a row.

Additionally, this feature includes massive changes to the project's code in order to implement something that is, at best, barely tangential to the project's functions. The commissions listing feature is meant as a simple directory of artists open for commissions, not some sort of sophisticated crypto-powered payment platform. We also do not intend to support NFTs, as this project is meant to be software to power image archives.

You're free to keep your project afloat, and if you intend to maintain it, I can offer to include a link to your project in the README file of our main repository, so that others can find it and use it if they so desire.

JasminDreasond commented 1 year ago

This code has no line related to NFT. Payment update is just to add support to artists who want to use crypto as a form of payment. At no time does the update removed support to USD.

If you think you have issues, then please let me know these issues to solve.

Meow commented 1 year ago

This change is too large for what it brings, and these features aren't what we consider necessary for the mainline Philomena software. This was the primary reason for closing this PR, even if the code quality was absolutely flawless.

My offer to add a link to your project to our README still stands.