philosophie / suspenders

A Rails template with our standard defaults, ready to deploy to Heroku.
MIT License
2 stars 1 forks source link

Pre commit hook, drop stairs config for .env and bin/setup #115

Closed ashwinv11 closed 6 years ago

ashwinv11 commented 6 years ago

Updated the README with info on how to skip this, and how to install the hooks when another user clones the project

patbenatar commented 6 years ago

@ashwinv11 On further thought, I don't think this is going to work for our use case. Nothing in the .git/ directory gets version controlled or moved around with the repo — i.e. after running suspenders you'll have a git commit hook in your local repo but when you push to GitHub, that hook won't be pushed, so the next person to clone won't get the hook. This is starting to justify the use of a tool to manage git hooks in the repo... see https://stackoverflow.com/questions/427207/can-git-hook-scripts-be-managed-along-with-the-repository

ashwinv11 commented 6 years ago

@patbenatar this is ready for review

patbenatar commented 6 years ago

:clap: :shipit: !

patbenatar commented 6 years ago

:+1: :shipit: @ashwinv11