Add CSS pack tag - Githubissues

philosophie / suspenders

A Rails template with our standard defaults, ready to deploy to Heroku.

MIT License

2 stars 1 forks source link

Add CSS pack tag #122

Closed mrkrlli closed 4 years ago

mrkrlli commented 4 years ago

@patbenatar @ashwinv11

This was missing and causing issues with webpacker in production. The extracted CSS was not getting output anywhere.
https://github.com/rails/webpacker/blob/master/docs/assets.md#import-from-node-modules

ashwinv11 commented 4 years ago

@mrkrlli Nice! we used to have an option to skip webpacker when generating a new app. Can we omit the extra css partial if we're skipping webpacker? Since stylesheet_pack_tag will probably return undefined method? Thanks!!

mrkrlli commented 4 years ago

@ashwinv11 Made some updates. If the webpack option is passed in, then we replace the javascript_include_tag with javascript_pack_tag and stylesheet_pack_tag. This only happens with the webpack flag.

mrkrlli commented 4 years ago

I also updated the bundler version to version 2. Running philsophies suspenders w/ the bunlder version was giving me errors before.

ashwinv11 commented 4 years ago

LGTM! :shipit: