philosophie / suspenders

A Rails template with our standard defaults, ready to deploy to Heroku.
MIT License
2 stars 1 forks source link

What needs to be removed or changed? #2

Closed patbenatar closed 9 years ago

patbenatar commented 9 years ago

@jdwolk @taboularasa @cltatman @pgdaniel can you guys let me know what you had to remove or change after using suspenders to generate a project?

taboularasa commented 9 years ago

@patbenatar I vote we work on this incrementally. Theres a lot of stuff in there, some of which we don't use because we're unfamiliar, less of it we don't use because we specifically don't like. We can start using this fork and discuss over pull requests during each new project that uses it?

patbenatar commented 9 years ago

@taboularasa I'm on board with that.. My goal with this issue is a first step to understand what everyone has been removing. The overlap between those lists will help us to consider whether we should introduce new tooling into our stack or prune out the obvious removals.

taboularasa commented 9 years ago

some things we probably can remove initially:

Things maybe we should remove?

Things we should evaluate?

Things we should probably add:

jdwolk commented 9 years ago
taboularasa commented 9 years ago

@jdwolk does pry-rails not take care of byebug dependency?

jdwolk commented 9 years ago

@taboularasa don't believe so -- every time I leave in just pry-rails it chokes on continue until I add pry-byebug.

Also byebug by itself doesn't integrate w/ pry. Hence byebug -> pry-byebug

jdwolk commented 9 years ago

screen shot 2015-06-08 at 10 19 20 am 2

taboularasa commented 9 years ago

@jdwolk okthen. I was thinking that the newer version of pry-rails was not trying to be backwards compatible

patbenatar commented 9 years ago

@cltatman @jdwolk can you guys provide your lists of what you removed for CGC and CSL as well? Thanks!

patbenatar commented 9 years ago

@taboularasa is the main problem with rack-timeout that it gets in the way of bindings during development?

patbenatar commented 9 years ago

WIP documentation of what to keep/remove/eval https://docs.google.com/spreadsheets/d/1NsBnXRFi_eQCgSUOXFhCcBA-NRYxj66P5qJ_0RoNKLU/edit#gid=0

etaymor commented 9 years ago

@patbenatar jumping in here, if you are setting up an option for bootstrap / foundation, could you set one up for Bourbon & friends too. NYC team tends to enjoy working with Bourbon / Neat / Bitters over Bootstrap and I find it a lot better to use

patbenatar commented 9 years ago

@etaymor Ha, we just ripped all that stuff out. But agreed they all have their use cases, depends on how heavily you want/need to customize

taboularasa commented 9 years ago

@etaymor @patbenatar if we're going with the command line flags it makes sense to have Bourbon to be one of the options. I can add that back in if you want

patbenatar commented 9 years ago

All initial removals and additions have been either completed or documented in individual issues. Items to be evaluated have individual tasks on the trello board