Should we include scss_lint?

lexi-lambda commented 9 years ago

I'm going to try using scss_lint on Fliper, and imo it's a good idea. CSS can be a bit of a free-for-all, and enforcing some kind of style guide would be a good idea. If we do this, we'll have to come up with a standard configuration, of course.

patbenatar commented 9 years ago

+1 for trying it out on Fliper. Report back here after eval and let's consider adding? Is there any community style guide or default settings of the linter that we can use with good results?

On Tue, Aug 4, 2015 at 11:08 AM, Alexis King notifications@github.com wrote:

I'm going to try using scss_lint on Fliper, and imo it's a good idea. CSS can be a bit of a free-for-all, and enforcing some kind of style guide would be a good idea. If we do this, we'll have to come up with a standard configuration, of course.

Reply to this email directly or view it on GitHub: https://github.com/philosophie/suspenders/issues/81

lexi-lambda commented 9 years ago

So far, it seems to have been successful, but we've only been using it for a week or so. I'll give a more comprehensive evaluation after we've been using it for a while.

The most comprehensive style guide I've found is sass-guidelin.es. It is self-described as follows:

An opinionated styleguide for writing sane, maintainable and scalable Sass.

From what I can tell, its usage isn't particularly widespread, but it is a comprehensive guide, and I agree with the majority of its policies. The other style guide I found was Chris Coyier's, which is much more lenient and mostly aligns with the default settings of scss-lint.

I think we have two options:

Follow the default configuration of scss-lint as closely as possible. The defaults are mostly sane. I've been using it with four small tweaks to the config, and it's been working well.
Enforce the style guide I mentioned above. This will likely be stricter, and it's incompatible with the default config in a few small ways, but it might be worth trying out.

I'd advocate for trying to use the configuration provided by the above style guide on a project and seeing how it goes. It seems like a good idea to me. For now, we'll probably just keep using the defaults on Fliper to see how that works out.

philosophie / suspenders

Should we include scss_lint? #81

I'm going to try using scss_lint on Fliper, and imo it's a good idea. CSS can be a bit of a free-for-all, and enforcing some kind of style guide would be a good idea. If we do this, we'll have to come up with a standard configuration, of course.