search

philroberts / FPDB-for-OSX

Free Poker DataBase development, with a focus on OSX.
http://fpdb.sf.net
56 stars 21 forks source link

Replace Tkinter code with pyQt code in fpdb_prerun.py #32

Open astephane opened 7 years ago

astephane commented 7 years ago

Replace Tkinter code with pyQt code in fpdb_prerun.py in order to remove Tkinter dependency.

philroberts commented 7 years ago

I think the point of fpdb_prerun is to check that dependencies are installed. Dependencies like pyQt. (of course, it is not safe to assume the tkinter works, either, but I didn't write this stuff.)

astephane commented 7 years ago

Sure, it's like a booststrap mechanism: no Qt UI packages are present, another Tk UI package is used to display in a window (usefull on Windows not so on Linux because we could simply trace to the console).

A better way to remove Tkinter could be to trace to the error log file and/or simply let Python module exception be raised and stop execution.

In deed, I installed Tkinter and I think this issue is not urgent.