search

philschmid / terraform-aws-sagemaker-huggingface

MIT License
46 stars 21 forks source link

Module constrains aws to ~> 4, but can be 5 #16

Open dsturnbull opened 1 year ago

dsturnbull commented 1 year ago

I've deployed and tested with hashicorp/aws 5.2.0 and it seems to be ok. Any reason not to bump it in the code here? Thanks.

philschmid commented 1 year ago

@dsturnbull would be awesome if you can open a PR to bump the version.

Bryson14 commented 7 months ago

I see that the this code has been merged into github, but using 0.8.1 off terrform brings in a version that only supports aws provider ~> 4.0. Does this just need to be pushed to terraform marketplace again?

module "huggingface_sagemaker" {
  source               = "philschmid/sagemaker-huggingface/aws"
  version              = "0.8.1"
  ...
Bryson14 commented 7 months ago

Looks like the last deployment to terraform was May 15, 2023, but this PR was in Jul 2023.