philss / rustler_precompiled

Use precompiled NIFs from trusted sources in your Elixir code
182 stars 26 forks source link

Make Rustler an optional dependency #12

Closed philss closed 2 years ago

philss commented 2 years ago

Users only need Rustler when forcing the build.

Closes https://github.com/philss/rustler_precompiled/issues/11

Screenshot from 2022-04-28 11-36-15

philss commented 2 years ago

@josevalim can you review this one?

philss commented 2 years ago

Also: after merge, should it be a patch or minor version release?

wojtekmach commented 2 years ago

Either is fine. If you are concerned about backwards compat, people who have projects with rustler precompiled already have rustler in their mix.lock so nothing changes for them.

philss commented 2 years ago

@wojtekmach cool, thanks! I think it can be a patch then :)