philss / rustler_precompiled

Use precompiled NIFs from trusted sources in your Elixir code
182 stars 26 forks source link

Precompiled NIFs do not work on Fedora and Red Hat machines #30

Closed Benjamin-Philip closed 1 year ago

Benjamin-Philip commented 1 year ago

This is because redhat uses the following target x86_64-redhat-linux. Other than a change in OS target variant and the missing "gnu" suffix, there is (as far as I know) no difference between x86_64-redhat-linux and x86_64-unknown-linux-gnu.

Possible solutions include:

Personally I prefer the 2nd option.

philss commented 1 year ago

I would use a list in the normalization code to treat "redhat" as "unknown". WDYT?

Benjamin-Philip commented 1 year ago

Sounds great! I'll send a PR.