search

philss / rustler_precompiled

Use precompiled NIFs from trusted sources in your Elixir code
181 stars 25 forks source link

Support the `redhat` Linux variant #32

Closed Benjamin-Philip closed 1 year ago

Benjamin-Philip commented 1 year ago

This commit adds support for the redhat Linux variant. This means targets such as:

will be treated as x86_64-unknown-linux-gnu.

Closes #30.

philss commented 1 year ago

@Benjamin-Philip that was fast! :D Thank you! :purple_heart:

Benjamin-Philip commented 1 year ago

that was fast! :D Thank you!

You're welcome! I need to make some contributions to Floki and Explorer. Having a working rustler precompiled version on main made that a little easier. Hence the rush.

It would be great if you could release a new minor version later this month, so that I can send patches to other repos to use a fedora compatible version.

philss commented 1 year ago

@Benjamin-Philip cool! :D

It would be great if you could release a new minor version later this month, so that I can send patches to other repos to use a fedora compatible version.

I just released version 0.5.2 with this fix. Please check that. I don't think Fedora has the same difference as we see in RedHat. In my system it returns "unknown". Do you know if this is something from the upcoming Fedora 37?

Benjamin-Philip commented 1 year ago

Do you know if this is something from the upcoming Fedora 37?

I'm running Fedora 36. It's definitely not something from F37 as I can find mentions of this target as far back as F16: https://bugzilla.redhat.com/show_bug.cgi?id=758528#c6. I'm searching for some official documentation regarding this.

I don't think Fedora has the same difference as we see in RedHat. In my system it returns "unknown".

What version of RHEL are you running?

philss commented 1 year ago

What version of RHEL are you running?

I'm also running Fedora 36 workstation :)

Benjamin-Philip commented 1 year ago

What version of RHEL are you running?

I'm also running Fedora 36 workstation :)

Me too!