search

philsturgeon / codeigniter-oauth2

NO LONGER ACTIVELY MAINTAINED. USE https://github.com/thephpleague/oauth2-client INSTEAD
http://getsparks.org/packages/oauth2/versions/HEAD/show
352 stars 177 forks source link

PHP 5 Ported #10

Closed toopay closed 12 years ago

toopay commented 12 years ago

Changes included :

Even if this pull did not make it, anyone who like to have this version, could grab from my fork. This just for acknowlegment, to you, @philsturgeon, that i use this time saving libraries for CI - OAuth, and modify to suit my needs.

Thanks.

philsturgeon commented 12 years ago

This fork is essentially redoing everything I had to undo to bring it over from Fuel to CodeIgniter. Seeing as everything is hidden behind a simple CodeIgniter interface anyway, what is the point of moving it over to be PHP 5.3 only?

I appreciate the thought and the effort, I guess I'm just not sure about the reasoning.

toopay commented 12 years ago

So your code were have been in this state, previously? Meh, silly me. You're also FUEL (those PHP 5.3) dev too right.

Yeah, the reasoning was clearly, to avoid those VeryLongCamelCase file-naming, and include() anywhere. But this also mean, providing flexibility, in case we need to add more provider, or adding more depedency within some class, without the need to adding more include() statement, in the future. I believe, many application, will soon ported their old OAuth into this one.

And particulary, in my case, Gas ORM, my ORM in CI app, was psr-0 compliant too, so this one not poluting my recent system.

But anyway, as i stated, whether this pull make it or not, i will leave those fork open, so for one who think that PHP 5.2 (and lower) no longer deserve some attention, could use this fork on their codeigniter application.

philsturgeon commented 12 years ago

Yes the Fuel code is very close to being PSR-0 compliant and 2.0 will become more so.

I am not talking about wether 5.3 or 5.2 is what we should be using, and to me it doesnt matter what version your other systems support. I'm just saying, is there a need for this?

I make my CI code 5.2 compatable and my Fuel code 5.3 compatable, because if I put 5.3 code into my codeingiter projects I up their requirements. If it works it works, it doesnt really need to be changed, right? :)