philsturgeon / codeigniter-oauth2

NO LONGER ACTIVELY MAINTAINED. USE https://github.com/thephpleague/oauth2-client INSTEAD
http://getsparks.org/packages/oauth2/versions/HEAD/show
349 stars 177 forks source link

Russian oauth providers #19

Closed Compilerrr closed 12 years ago

Compilerrr commented 12 years ago

www.vk.com and www.yandex.ru providers added If these are ok, i'll add odnoklassniki.ru and mail.ru later.

Compilerrr commented 12 years ago

Since for one application I use only one client/secret id per provider i think it's nice place for default config. Otherwise you need some code to choose right client/secret id for specific provider. But in general, i agree with you, it looks not good :)

philsturgeon commented 12 years ago

That will mess up how all code built around the provider is done though. Make it work like every other provider or I cannot merge this!

Compilerrr commented 12 years ago

I thought i've done it... I'm new to git maybe i'm doing something wrong? I made a commit in my fork, is it enough?