search

philtabor / Youtube-Code-Repository

Repository for most of the code from my YouTube channel
861 stars 480 forks source link

Little issue in ddqn_keras.py #8

Open jlarghi opened 4 years ago

jlarghi commented 4 years ago

Hi Phil, there is a small issue in the method update_network_parameters(self), I think that should be: self.q_target.set_weights(self.q_eval.get_weights())

instead of: self.q_target.model.set_weights(self.q_eval.model.get_weights())

Thanks for your code and your videos! These are really useful for me. Jose.

Gonm1 commented 4 years ago

I have tested it, and I get a warning about Sequential.model has been deprecated. So I do not think that what you are saying is correct.

UserWarning: Sequential.model is deprecated. Sequential is a subclass of Model, you can just use your Sequential instance directly.