search

philtoms / mithril.elements

Adds composable custom element types to Mithril
MIT License
42 stars 4 forks source link

edit .gitignore and remove npm-debug.log & .DS_Store #1

Closed Draggha closed 9 years ago

Draggha commented 9 years ago

Hi!

Just as the title says: There is a npm-debug.log in your codebase which is not needed.

As far as the rest goes: Great job! I like the approach to reusable components. I'm building a tree view component myself right now. In a couple of weeks I may have some spare time to see how it would look like as a mithril.element. :) I'll give you a heads-up how it goes.

Regards, Johann

Draggha commented 9 years ago

Hi Phil,

on second thought: Since .DS_Store also lies within this project just remove both (.DS_Store and .npm-debug.log) and add them to .gitignore.

// .gitignore npm-debug.log .DS_Store

Regards, Johann

philtoms commented 9 years ago

Hi Johann,

Thanks for pointing that out. Your tree sounds interesting. Of course I'd love to see it done as an element!  Let me know how it turns out.

Cheers Phil

Sent from Samsung Mobile

-------- Original message --------
From: Johann Haaf notifications@github.com
Date:06/01/2015 13:07 (GMT+00:00)
To: "philtoms/mithril.elements" mithril.elements@noreply.github.com
Cc:
Subject: [mithril.elements] remove npm-debug.log (#1)
Hi! Just as the title says: There is a npm-debug.log in your codebase which is not needed. As far as the rest goes: Great job! I like the approach to reusable components. I'm building a tree view component myself right now. In a couple of weeks I may have some spare time to see how it would look like as a mithril.element. :) I'll give you a heads-up how it goes. Regards, Johann — Reply to this email directly or view it on GitHub.