search

philvessey / NextDepartures

NextDepartures is a .NET Library that queries GTFS (General Transit Feed Specification) data sets stored locally or in an Azure SQL Database. The library will work with any well formed GTFS data set.
MIT License
1 stars 1 forks source link

Proper usage of data types #18

Closed hypervtechnics closed 4 years ago

hypervtechnics commented 4 years ago

E.g. DepartureTime in Service class.

philvessey commented 4 years ago

I have pushed the first part of my refactoring to use the models provided by the GTFS library. Correct data types are now used across the libraries except for DepartureTime in the Service class which I will work on now the main refactoring has been completed.

hypervtechnics commented 4 years ago

@philvessey Are there any problems I could help solving?

philvessey commented 4 years ago

I should be ok with it - I will reach out if I run into issues.

philvessey commented 4 years ago

I have done some more refactoring so that now the Departure and Service classes have:

public DateTime DepartureDateTime public TimeOfDay? DepartureTime

This brings them into line with the GTFS classes using TimeOfDay and gives the user a lot more options to display the times instead of just outputting a string. I need to do some testing on it which I will do tomorrow and if all OK I will push up the changes.