search

phingofficial / guide

The Phing user guide
Other
3 stars 7 forks source link

Split "Optional tasks" chapter #34

Closed jawira closed 3 years ago

jawira commented 3 years ago

Could you please double check that everything is ok please? I'm not a docbook expert :)

jawira commented 3 years ago

See issue #33

mrook commented 3 years ago

Wow @jawira, this is great work.

jawira commented 3 years ago

Ok, sorry about the delay but I totally forgot about this PR.

There are two files referencing optionaltasks.xml https://github.com/phingofficial/guide/search?q=optionaltasks.xml

  1. The first one is master.xml, I didn't change anything in this file since it simply does an include
  2. I updated source/chapters/about.xml with new instructions.

Please don't hesitate to tell me if I have to change something else :)

mrook commented 3 years ago

@jawira can you update the PR?

jawira commented 3 years ago

@mrook I updated PR with changes from #35 and #36 , please let me know if something else is missing.