phingofficial / phing

PHing Is Not GNU make; it's a PHP project build system or build tool based on Apache Ant.
https://www.phing.info
GNU Lesser General Public License v3.0
1.16k stars 319 forks source link

Error resolving proxy #1391

Closed jawira closed 4 years ago

jawira commented 4 years ago

Hi, I had the habit to add proxy configuration to my buildfiles. Because in linux you can set your proxy using an environment variable I simply passed this variable to a property:

<property name="phing.http.proxy" value="${env.http_proxy}"/>

Currently I don't work behind a proxy anymore, so ${env.http_proxy} doesn't exists. This wasn't a problem until I updated to Phing 3.0.0-alpha4:

$ phing -v
Phing 3.0.0-alpha4

$ phing emoji-list:download
Buildfile: /home/jawira/PhpstormProjects/emoji-catalog/build.xml

Emoji catalog > emoji-list:download:

BUILD FAILED
/home/jawira/PhpstormProjects/emoji-catalog/build.xml:68:98 cURL error 5: Could not resolve proxy: ${env.http_proxy} (see https://curl.haxx.se/libcurl/c/libcurl-errors.html)

Total time: 0.0630 seconds

Apparently now phing.http.proxy must be a valid proxy if it's declared. I understand that this could be related to the use of Guzzle library, but do you thing is it possible to revert to the previous behavior?

siad007 commented 4 years ago

Thanks for the report - this sounds like a refactoring bug as you mentioned and should be fixed ASAP

Jawira Portugal notifications@github.com schrieb am Do. 17. Sept. 2020 um 11:24:

Hi, I had the habit to add proxy configuration to my buildfiles. Because in linux you can set your proxy using an environment variable I simply passed this variable to a property:

Currently I don't work behind a proxy anymore, so ${env.http_proxy} doesn't exists. This wasn't a problem until I updated to Phing 3.0.0-alpha4:

$ phing -v

Phing 3.0.0-alpha4

$ phing emoji-list:download

Buildfile: /home/jawira/PhpstormProjects/emoji-catalog/build.xml

Emoji catalog > emoji-list:download:

BUILD FAILED

/home/jawira/PhpstormProjects/emoji-catalog/build.xml:68:98 cURL error 5: Could not resolve proxy: ${env.http_proxy} (see https://curl.haxx.se/libcurl/c/libcurl-errors.html)

Total time: 0.0630 seconds

Apparently now phing.http.proxy must be a valid proxy if it's declared. I understand that this could be related to the use of Guzzle library, but do you thing is it possible to revert to the previous behavior?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/phingofficial/phing/issues/1391, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQMYRNVH2N7AIJEZNHORVDSGHIT5ANCNFSM4RQEJAYQ .

siad007 commented 4 years ago

@jawira would you mind to check the pr? thx

jawira commented 4 years ago

Sure! https://github.com/jawira/emoji-catalog/blob/master/build.xml

jawira commented 4 years ago

@jawira would you mind to check the pr? thx

Looks good to me 👍🙂