search

phip1611 / ttfb

Library + CLI-Tool to measure the TTFB (time to first byte) of HTTP requests. Additionally, this crate measures the times of DNS lookup, TCP connect and TLS handshake.
MIT License
41 stars 11 forks source link

Prevent ttfb library from blocking other libraries usage of newer regex version #29

Closed Firaenix closed 9 months ago

Firaenix commented 9 months ago

As title says.

My previous commit caused some issues when updating to 1.8.0 if the workspace importing ttfb was already using (or a dependency of your workspace was already using) Regex 1.10+.

phip1611 commented 9 months ago

Why does it block other libraries from using the new regex version at all? It should be no problem to have regex 1.9 and 1.10 twice in the same binary - there is however a size impact of the final binary.

Bumping the regex version is a breaking change as the MSRV of the lib changes. 1.64 is 1 year old. I think, having a breaking change with a new release is fine.

But I still do not really know what you mean by that ttfb currently blocking other libraries from using newer version of regex.

Firaenix commented 9 months ago

So this is what started happening to me after bumping to 1.8.0.

I use a library called machine-uid as well as libp2p which require regex 1.10 or above, which is causing my project to not compile due to conflicting dependency versions.

image

phip1611 commented 9 months ago

I think bumping the MSRV for the lib is fine. Will do so in the next couple of days. Thanks for the report!

I can reproduce it.

image