phips28 / facebook-live-video

Stream a website with phantomjs to Facebook Live via ffmpeg (video) and collect Facebook reactions
MIT License
90 stars 32 forks source link

Not staying at 30fps #4

Open mmccaff opened 7 years ago

mmccaff commented 7 years ago

I noticed that the "keep ffmpeg stream at 30 fps" issue was marked as done in the readme, but I am seeing the same behavior where it starts at 30 and then drops down.

FWIW, I also noticed that if I include more images in the web site, it drops down much lower, to around 2 or 3 fps.

What was the fix for that? Is it in the master branch? Are you really able to hold steady at 30 fps?

phips28 commented 7 years ago

We fixed this with the silent audio streaming. its not staying at 30 fps but it works for me.

do you have problems with the stream?

mmccaff commented 7 years ago

The stream works with the web page as it is, but it seems when the page includes images with more colors (like a photograph) the fps is much less (~2 fps) and when it is that low, the stream does not work.

So far I have tried lowering the quality of the png output from phantom, but that made no difference.

Curious if you see the same problem if including more "complex" images on the web page.

On Nov 21, 2016 10:49 PM, "Phil" notifications@github.com wrote:

We fixed this with the silent audio streaming. its not staying at 30 fps but it works for me.

do you have problems with the stream?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/phips28/facebook-live-video/issues/4#issuecomment-262140565, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_c7UMSOi7erjzHGGXTe0dy8bucAlgPks5rAmZigaJpZM4K4742 .

phips28 commented 7 years ago

Can you share an example code in a branch?

Best, Philipp Holly

On Nov 22, 2016, at 5:19 AM, Matt McCaffrey notifications@github.com wrote:

The stream works with the web page as it is, but it seems when the page includes images with more colors (like a photograph) the fps is much less (~2 fps) and when it is that low, the stream does not work.

So far I have tried lowering the quality of the png output from phantom, but that made no difference.

Curious if you see the same problem if including more "complex" images on the web page.

On Nov 21, 2016 10:49 PM, "Phil" notifications@github.com wrote:

We fixed this with the silent audio streaming. its not staying at 30 fps but it works for me.

do you have problems with the stream?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/phips28/facebook-live-video/issues/4#issuecomment-262140565, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_c7UMSOi7erjzHGGXTe0dy8bucAlgPks5rAmZigaJpZM4K4742 .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

mmccaff commented 7 years ago

It looks like FB banned using reactions as a voting mechanism:

https://en.facebookbrand.com/assets/reactions/

So I've stopped trying to learn what the problem was, but for the record, I did find that it was definitely the images (photographs) that slowed down the fps. Tests showed:

Finally, I tested one single image which included all four of the photographs and it was 3.7 fps and streamed. So, it seemed like the fps went down with the "complexity" of the display.

Matt