phips28 / gh-action-bump-version

GitHub Action for automated npm version bump.
MIT License
336 stars 249 forks source link

Filter out empty strings for major/minor bump checks #216

Closed timjrobinson closed 1 year ago

timjrobinson commented 1 year ago

When setting major-wording or minor-wording to '' (which I assumed would disable all word search checks) it actually makes every commit a major bump, becuase it searches for that empty string in the commit message.

This PR filters out empty strings so that the major/minor words array is empty instead, as a user would expect.

phips28 commented 1 year ago

thx 🙂
https://github.com/phips28/gh-action-bump-version/releases/tag/v9.1.6