phire / doom3.gpl

Doom 3 GPL source release
GNU General Public License v3.0
15 stars 4 forks source link

bad cmakelists for xxf86vm and asound #16

Open andrew-aladev opened 12 years ago

andrew-aladev commented 12 years ago

hello! your cmakelists is good but not perfect. it has no search to libxxf86vm-dev and libasound2-dev and thats why cause errors on build. here is a patch:

andrew-aladev commented 12 years ago

diff --git a/neo/CMakeLists.txt b/neo/CMakeLists.txt index e37cb81..ba25a6a 100644 --- a/neo/CMakeLists.txt +++ b/neo/CMakeLists.txt @@ -59,6 +59,10 @@ FIND_PACKAGE (CURL REQUIRED) FIND_PACKAGE (JPEG REQUIRED) INCLUDE_DIRECTORIES (${JPEG_INCLUDE_DIR})

+#alsa sound +FIND_PACKAGE (ASOUND REQUIRED) +INCLUDE_DIRECTORIES (${ASOUND_INCLUDE_DIR}) +

Find Vorbis Libs

FIND_PACKAGE (Vorbis REQUIRED) INCLUDE_DIRECTORIES (${VORBIS_INCLUDE_DIR}) @@ -76,7 +80,8 @@ INCLUDE_DIRECTORIES (${OPENAL_INCLUDE_DIR}) IF (UNIX AND NOT APPLE) # Despite being unix, Apple doesn't primarily use X11

X11

FIND_PACKAGE (X11 REQUIRED)
andrew-aladev commented 12 years ago

it looks bad: i cant attach a patch to issue. okey I would fork it now

andrew-aladev commented 12 years ago

see. I've created a pull request. it is more readable